Blocking review comments need exit conditions
Blocking review comments need exit conditions
If you block, define what unblocks.
Bad:
This error handling feels wrong.
Better:
Blocking: return 409 instead of 500 when the workflow already exists. Once that path is covered, I'm good.
Why
A blocking comment makes you a co-owner of the PR. The author now needs to make a change and come back to you. If your comment does not explain the condition for approval, you have created limbo.
Limbo is not kind. The author does not know whether to act, wait, defend the current approach, or merge anyway.
Comment intent
Make the intent explicit:
blocking: must change before mergequestion: needs clarification; say whether it blockssuggestion: improvement the author can accept or declinefollow-up: worth doing, but not in this PRnit: genuinely optional, no response neededFYI: context for the author or future readers
Hiding a blocking concern inside a soft comment can feel polite, but it mostly creates uncertainty. If it blocks, request changes. If it does not, say that.
Reviewer co-ownership has limits. Own the path to resolving your blockers. Do not become a shadow author or take over someone else's work by review comment.