Do the real review upfront

Do the real review upfront

Avoid shifting the goal posts by asking for one set of changes, waiting for the author to implement them, then raising more issues that were visible in the original diff.

The author hears your first review as a finish line. When they do the requested work and the finish line moves, it feels like the review was not real the first time.

The nuance

This does not mean reviewers only get one pass. People miss things. New issues can become visible after changes. That is normal.

But late comments should have a higher bar.

If the issue was visible from the start and is not important, let it go or raise a follow-up. If it does matter, own the miss:

I missed this in my first pass, but I think it blocks because...

That small bit of ownership matters.

PR shape matters too

If a PR is large enough that reviewers are likely to drip-feed comments across several rounds, that is partly a PR-shape problem. Small does not mean artificially tiny, but a PR should be the smallest coherent unit that can be reviewed, merged, and understood.

See also